Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--rm should be a command instead of an option #2911

Open
aequitas opened this issue Oct 3, 2018 · 3 comments
Open

--rm should be a command instead of an option #2911

aequitas opened this issue Oct 3, 2018 · 3 comments
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: API Change This issue describes an API change. Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@aequitas
Copy link

aequitas commented Oct 3, 2018

Currently I find it hard to (re)discover the --rm function to 'reset' an environment. For me it would make more sense to have it as a command rather than a option as it more an action taken instead of a modifier like --two/--three.

Right now it doesn't function as an modifier option as well. For example, running pipenv --rm sync would be useful as it could first remove the environment before syncing it anew, but currently skips the --rm.

My suggestion would be to move the functionality to a remove command.

@techalchemy
Copy link
Member

This makes sense (although making an API change at this point will be challenging)

Either way you will need to propose it as a Markdown document to the peeps folder at the root of the repository so that Kenneth sees it and can review it. Probably you can just make a document that contains what you already wrote here as an explanation. Thanks for the suggestion!

@techalchemy techalchemy added Status: Requires Approval This issue requires additional approval to move forward. Type: API Change This issue describes an API change. Status: Requires PEEP This issue requires an accompanying enhancement proposal labels Oct 30, 2018
@matteius matteius added Type: Enhancement 💡 This is a feature or enhancement request. hacktoberfest Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. and removed Status: Requires Approval This issue requires additional approval to move forward. Status: Requires PEEP This issue requires an accompanying enhancement proposal labels Mar 4, 2023
@matteius
Copy link
Member

matteius commented Mar 4, 2023

I think it makes sense -- we can still support --rm for a period of time, but making it a command sounds good along with a command to activate the virtualenv only (not invoking a sub-shell).

@vishalagrawal22
Copy link

vishalagrawal22 commented Oct 1, 2023

Hi @matteius,
I would like to take this up. It is my first time here. Can you help me start with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor Candidate The issue has been identified/triaged and contributions are welcomed/encouraged. hacktoberfest Type: API Change This issue describes an API change. Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

4 participants