.freeze renamed to .lock?

[mahmoud]

I recall a long discussion on #43 and elsewhere, where a decent consensus was reached to change to freeze files, so as to avoid confusion with file locking. I may be confused, but this seems to have been unilaterally reverted? I can't find any further discussion.

[sethmlarson]

I think the reason we stuck with .lock is because it's kind of a standard for packaging (Cargo.lock etc)

[jacebrowning]

This probably isn't the place to discuss it, but I would really like to see:

pip.toml and pipfreeze.json

The filenames tells you one is the input for pip and the other is a "frozen" set of requirements. The extensions tell you the format of the file and automatically trigger syntax highlighting in editors.

[sethmlarson]

@jacebrowning Most IDEs can be configured to see a file-name and automatically interpret the structure properly. Also some are smart enough to recognize what the file format is without any name hinting at all. I can confirm that PyCharm and friends do this.

[mahmoud]

@SethMichaelLarson You say "etc." but in my years of experience with packages, I'm not familiar with another, whereas I'm quite used to seeing ".lock" used for lockfiles. I'm also concerned that this sudden change in direction occurred without a tracking issue or announcement.

[sethmlarson]

@mahmoud Yarn.lock? Golang uses the name lock.json for dep? Using 'lock' isn't exactly unheard of.

[mahmoud]

Considering the audience is primarily Python programmers, you may want to consider your audience. People have been pip freeze-ing long before any of these managers existed.

[sethmlarson]

But pip freeze is already sub-par because Pipfiles are so much more than module name and version. It may as well be pip list.

I see your point and I actually agree that .lock may be undesirable (for the reasons I already listed in the linked issue) but I don't think it's that big of a deal to use it. That's just my opinion. :)

[mahmoud]

Cool, thanks for closing this @kennethreitz, glad you could chime in. ☮️

[kennethreitz]

literally every community calls it locking, so it makes sense to call it a lockfile. pipenv is already using this, and it works well.

[kennethreitz]

anything's up to change as the project evolves though, no need to discuss it here.

[sethmlarson]

@kennethreitz Remember that pipenv and pipfile are separate projects though. Pipenv depending on things for this (still somewhat in design stage?) project shouldn't really be an argument for anything relating to pipfile.