Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert using platformdirs by default for windows and macos #1257

Closed
Gitznik opened this issue Feb 19, 2024 Discussed in #1247 · 1 comment · Fixed by #1297
Closed

revert using platformdirs by default for windows and macos #1257

Gitznik opened this issue Feb 19, 2024 Discussed in #1247 · 1 comment · Fixed by #1297
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed macOS windows

Comments

@Gitznik
Copy link
Contributor

Gitznik commented Feb 19, 2024

Discussed in #1247

How would this feature be useful?

Makes the default behavior on Windows and MacOS more robust, by fixing some edge cases with sandboxing in windows and spaces in shebangs on macos. For more details, please see the discussion.

Describe the solution you'd like

Default behavior on Windows and MacOS reverts to pre #1001, for Linux it stays as is.
Revert the current path fallback behavior for paths in the pre #1001 location to fallback to the platformdirs locations post #1001 instead on Windows and MacOS.

Describe alternatives you've considered

Sticking to the platformdirs locations, as described in the discussion. There was no support for that idea though.

@Gitznik
Copy link
Contributor Author

Gitznik commented Mar 12, 2024

Should probably wait for #1281 to be merged as that will make this change a lot easier and prevent a lot of conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed macOS windows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants