feat: preserve language attribute for code blocks #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
In order to allow the `lang` attribute on `pre` code blocks, add it to the post-syntax highlighting step, and then allow through the sanitizer. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
di
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As surfaced in #200, we were stripping away the
langattribute in the resulting<pre>blocks.While GitHub's UI may add more tags/behaviors based on their syntax highlighting rendering engine, at the very least we can try to preserve the
langattribute after we run our pygments syntax highlighter.This change doesn't conform 100% to the GFM output on GitHub, as they apply another form of syntax highlighting to the HTML that removes the
langattribute from known languages after being highlighted. I don't know yet which process they use for that.Resolves #200
Signed-off-by: Mike Fiedler miketheman@gmail.com