CI: Check for uncommitted table alteration #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the checks would always indicate a failure, although the scenarios are not intended to succeed. Now, they will only fail on an unchanged `table.md` despite a different outcome in the scenario run. Co-authored-by: Anderson Bravalheri <320755+abravalheri@users.noreply.github.com>
chrysle
force-pushed
the
ci-check-table-alteration
branch
3 times, most recently
from
c10475a
to
8333e87
Compare
Before, the checks would always indicate a failure, although the scenarios are not intended to succeed. Now, they will only fail on an unchanged `table.md` despite a different outcome in the scenario run. Co-authored-by: Anderson Bravalheri <320755+abravalheri@users.noreply.github.com>
chrysle
force-pushed
the
ci-check-table-alteration
branch
from
8333e87
to
33bfbdf
Compare
abravalheri
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Thank you @chrysle . I think that is a nice way of checking for this repository.
chrysle
force-pushed
the
ci-check-table-alteration
branch
from
ff57915
to
49ebd06
Compare
|
@pradyunsg Gentle ping. |
webknjaz
reviewed
Apr 28, 2024
…ci-check-table-alteration
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <578543+webknjaz@users.noreply.github.com>
chrysle
force-pushed
the
ci-check-table-alteration
branch
from
ef5868f
to
5095dcd
Compare
webknjaz
reviewed
Apr 29, 2024
And use better syntax to append to `GITHUB_OUTPUT`. Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
pradyunsg
approved these changes
Apr 29, 2024
|
Thank you all for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the checks would always indicate a failure, although the scenarios are not intended to succeed. Now, they will only fail on an unchanged
table.mddespite a different outcome in the scenario run.I also plan to schedule the run, so that the compatibility matrix is kept up-to-date.
Closes #26.