-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to uninstall egg-link on windows #1159
Comments
You're doing it wrong. You want |
Thanks @xoviat, it works fine now with |
I don't know how pip does it but installing is a frontend responsibility. It won't be fixed in setuptools. |
See PEP 427, 518, and 517 for more information. |
@FarmerSez : That's really surprising that an attempt to remove a file immediately after closing it would fail. That sounds like a bug in PyPy to me. Can you try replicating the failure and if you can with a simple Python script file the issue upstream with PyPy? I'd be happy to fix it here except that the behavior of Setuptools as I understand it is correct. |
@jaraco sure, I'll look into it 😃 |
Hey there!
For the past few days I've been struggling with a bug in
pydocstyle
, which is described in this long and tedious SOVF question.To sum it up, when I was running in a
pypy
environment and tried to testsetup.py develop
andsetup.py develop --uninstall
, windows raised error 32 saying that theegg-link
file can't be removed for it is being used by another process.I came across this bug report, and in particular:
I opened
setuptools\command\develop.py
and inuninstall_links
(line 152) I saw this:So I thought to myself, "maybe the file is being held by the same process? perhaps windows doesn't clear the resources fast enough?". So I added this bit of code to it:
And... voila.
I'd open a PR, but I seriously doubt that that's the way to go about it. I'm open to suggestions and will happily send a PR to fix it 😃
Shachar.
EDIT:
Well, obviously I had to emberrass myself an write a bug in my fix 😊
The error still happens after changing "fixing" the "fix" to:
Any ideas?
Shachar.
The text was updated successfully, but these errors were encountered: