Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilitate dealing with _validate_pyproject for re-packages/OS-package-maintainers #3229

Merged
merged 10 commits into from Mar 31, 2022
Merged

Facilitate dealing with _validate_pyproject for re-packages/OS-package-maintainers #3229

merged 10 commits into from Mar 31, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Mar 30, 2022 •
edited

Summary of changes

  • Update generated pyproject.toml validation code according to validate-pyproject v0.7.1
  • Move setuptools/_vendor/_validate_pyproject to setuptools/config
    • This module is not exactly a vendored dependency. Instead it corresponds to the JSON Schemas pre-compiled to be used in a standalone fashion + some supporting code.
  • Disable automatic download of trove-classifiers to facilitate reproducibility
  • Create a new task tox -e generate-validation-code to update validation code.

Closes #3225.
Closes abravalheri/validate-pyproject#31 (I don't know if this works).

Pull Request Checklist

abravalheri
abravalheri commented Mar 30, 2022
View reviewed changes
.coveragerc Outdated Show resolved Hide resolved
@abravalheri abravalheri changed the title Facilitate for re-packages/OS-package-maintainers to deal with _validate_pyproject Facilitate re-packages/OS-package-maintainers to deal with _validate_pyproject Mar 30, 2022
@abravalheri abravalheri changed the title Facilitate re-packages/OS-package-maintainers to deal with _validate_pyproject Facilitate dealing with _validate_pyproject for re-packages/OS-package-maintainers Mar 30, 2022
@abravalheri abravalheri marked this pull request as ready for review March 30, 2022 21:29
@abravalheri abravalheri merged commit b9d3f99 into pypa:main Mar 31, 2022
@abravalheri abravalheri deleted the issue-3225 branch February 16, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't fetch trove-classifiers from the web Move _validate_pyproject out of _vendor
1 participant
@abravalheri