Apply workaround on all versions of Python. #3739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaraco
changed the title
|
In that bug, I indicated that applying a workaround on all versions of Python was problemmatic, so I'm uneasy applying this change without more explanation why it's the correct fix. Also, there are other efforts (python/importlib_metadata#396) to address the issue at its core. Can you add some more detail about why this fix is the correct one, what environments it helps? What's more important is going to be to understand how this change might unintentionally affect things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #3452
Pull Request Checklist
changelog.d/.(See documentation for details)