Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] requiring 32-bit or 64-bit Python in setuptools.setup #3746

Open
1 task done
jamesbraza opened this issue Jan 4, 2023 · 3 comments
Open
1 task done

[FR] requiring 32-bit or 64-bit Python in setuptools.setup #3746

jamesbraza opened this issue Jan 4, 2023 · 3 comments
Labels
enhancement Needs Discussion Issues where the implementation still needs to be discussed. Waiting User Feedback

Comments

@jamesbraza
Copy link

jamesbraza commented Jan 4, 2023

What's the problem this feature will solve?

Sometimes in life, one finds oneself doing major software archaeology with code from a decade ago. 馃ゲ

OpenOPC-Python3x works with pywin32, which I have discovered only works with 32-bit Python. I confirmed this to be true with rigorous testing, and recorded it here ya-mouse/openopc#22.

Now, in my package where I import OpenOPC and pywin32, I would like to use setuptools to enforce a 32-bit dependency.

Describe the solution you'd like

setuptools.setup has the python_requires kwarg to require a certain version range of Python.

I think it would be good to add processor_type or something similar to enforce Python being 32-bit, 64-bit, etc.

Alternative Solutions

No response

Additional context

No response

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@jamesbraza jamesbraza added enhancement Needs Triage Issues that need to be evaluated for severity and status. labels Jan 4, 2023
@abravalheri
Copy link
Contributor

Hi @jamesbraza, sorry for replying to this issue just now and thank you for starting the discussion.

I think that in this case it would be necessary to coordinate which new kinds of metadata (regarding the number of bits) it would be necessary to expose and how the installer (e.g. pip would handle that). In the end of the day that would be an standardisation effort.

So I think the best place to discuss that would be the Python Packaging discourse.

@abravalheri abravalheri added Needs Discussion Issues where the implementation still needs to be discussed. Waiting User Feedback and removed Needs Triage Issues that need to be evaluated for severity and status. labels Jun 20, 2023
@jamesbraza
Copy link
Author

All good. Fwiw, this request is now more useful, as many libs are dropping support for 32-bit, and it's breaking installs:

I will make a Discourse thread shortly

@jamesbraza
Copy link
Author

Okay I made this: https://discuss.python.org/t/idea-enforcing-32-bit-vs-64-bit-support-in-setuptools

Feel free to close this out in favor of that discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Needs Discussion Issues where the implementation still needs to be discussed. Waiting User Feedback
Projects
None yet
Development

No branches or pull requests

2 participants