Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "type information included by default"'s added version #4182

Merged
merged 3 commits into from Jan 11, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Jan 11, 2024

Summary of changes

Changed versionadded for "type information included by default"'s feature from v68.3.0 to v69.0.0. v68.3 doesn't exist, it was obviously meant to aim for "the next version", but probably forgot to update. CC @Danie-1

Closes

Pull Request Checklist

@abravalheri abravalheri merged commit 2c28939 into pypa:main Jan 11, 2024
23 checks passed
@abravalheri
Copy link
Contributor

Thank you very much!

@Avasam Avasam deleted the patch-1 branch January 11, 2024 08:49
@@ -0,0 +1 @@
Changed ``versionadded`` for "Type information included by default" feature from ``v68.3.0`` to ``v69.0.0`` -- by :user:Avasam`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Avasam looks like you forgot a backtick here and now rendering is broken in the changelog. You can fix this by making a PR updating the changelog directly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ironic, my PR to fix the changelog will need a PR to fix the changelog ^^"

@Avasam Avasam mentioned this pull request Apr 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants