Append arbitrary args instead of prepending. #4217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshilliard
force-pushed
the
append-arbitrary-args
branch
2 times, most recently
from
8585c5e
to
304c802
Compare
2 tasks
|
Closing in favor of #4218. |
jameshilliard
force-pushed
the
append-arbitrary-args
branch
2 times, most recently
from
91f3400
to
7f256d4
Compare
abravalheri
reviewed
Feb 22, 2024
jameshilliard
force-pushed
the
append-arbitrary-args
branch
from
7f256d4
to
44bad89
Compare
|
Thank you very much @jameshilliard for working on this. Would you like to add a regression test so that we don't accidentally break the use case in the future? |
jameshilliard
force-pushed
the
append-arbitrary-args
branch
2 times, most recently
from
29680f1
to
1f0cefb
Compare
jameshilliard
force-pushed
the
append-arbitrary-args
branch
from
1f0cefb
to
1719601
Compare
Test added that should catch this issue. |
|
Thank you very much @jameshilliard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Restore original argument append behavior which was changed in #4079.
Fixes:
Pull Request Checklist
newsfragments/.(See documentation for details)