Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize and centralize StrPath TypeAlias #4241

Merged
merged 1 commit into from Mar 3, 2024

Conversation

Avasam
Copy link
Contributor

@Avasam Avasam commented Feb 27, 2024

Summary of changes

Brought all aliases _Path and unions str | Path and str | PathLike closer to typeshed's StrPath and centralized the TypeAlias in setuptools._path.

Works towards #2345

Pull Request Checklist

  • Changes have tests (existing tests should pass, type-checking tests are coming in a different PR)
  • News fragment added in newsfragments/.
    (See documentation for details)

@@ -0,0 +1 @@
Improvements to `Path`-related type annotations when it could be ``str | PathLike`` -- by :user:`Avasam`
Copy link
Contributor Author

@Avasam Avasam Feb 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked this as misc rather than feature because for now type-checking users will still use types-setuptools

@jaraco jaraco merged commit 80da90c into pypa:main Mar 3, 2024
21 of 23 checks passed
@Avasam Avasam deleted the StrPath-TypeAlias branch March 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants