Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setuptools 25.1.4 adds extra quotes on LIBPATH #722

Closed
minrk opened this issue Aug 5, 2016 · 2 comments · Fixed by #723
Closed

setuptools 25.1.4 adds extra quotes on LIBPATH #722

minrk opened this issue Aug 5, 2016 · 2 comments · Fixed by #723

Comments

@minrk
Copy link
Contributor

minrk commented Aug 5, 2016

#715's quoting has caused my appveyor builds to start failing with 25.1.4, due to some extra quoting.

With setuptools 25.1.3, builds succeed, and with 25.1.4 they fail.

The key difference:

on 25.1.3, the link command had args like:

"/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB"

on 25.1.4, they look like:

"/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB""

(note the extra quotes).

These are CPython 3.5 x86 builds on appveyor; I don't know what other versions are affected.

@ft1337
Copy link

ft1337 commented Aug 5, 2016

CPython 3.5 amd64 builds on Windows fail, too.

@anthrotype
Copy link

sorry, I was too fast. It's actually still not working for me either, even after #723.
I probably had incorrectly installed setuptools from the PR branch.

Before #723 was merged, I would get something like this:

"/LIBPATH:"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB""

after #723 I get this:

""/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\LIB""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants