Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nice error for old git versions. Documentation of version requirements. #540

Closed
tbenthompson opened this issue Mar 17, 2021 · 2 comments
Closed

Comments

@tbenthompson
Copy link

tbenthompson commented Mar 17, 2021

I just upgraded a CI server from setuptools_scm==5.0.2 to setuptools_scm==6.0.0 and immediately ran into errors due to:

git log -n 1 HEAD --format=%cI

not being valid on our git version 1.8.3.1. Since that git version is almost six years old now, I don't expect support, but I wanted to suggest adding some documentation to the README and perhaps a git version check into the code.

Currently the above command leads to the error:

        raise ValueError("time data %r does not match format %r" %
    ValueError: time data '%cI' does not match format '%Y-%m-%d'

It would be much nicer to see an error saying that my git version is not supported.

Thanks very much!

@RonnyPfannschmidt
Copy link
Contributor

this was fixed on version 6.0.1 see #537 and #538

@tbenthompson
Copy link
Author

Ah thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants