Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in activate.bat #126

Closed
cotsog opened this issue May 11, 2011 · 2 comments
Closed

Error in activate.bat #126

cotsog opened this issue May 11, 2011 · 2 comments

Comments

@cotsog
Copy link

cotsog commented May 11, 2011

Hi,

I think there is an error in the activate.bat batch file

See https://github.com/pypa/virtualenv/blob/develop/virtualenv_support/activate.bat#L24.

What it does actually is to add "goto SKIPPATH;" in my PATH environment variable.

Here is my suggestion:

Replace

if defined _OLD_VIRTUAL_PATH set PATH=%_OLD_VIRTUAL_PATH%; goto SKIPPATH

By

if defined _OLD_VIRTUAL_PATH set PATH=%_OLD_VIRTUAL_PATH%
if defined _OLD_VIRTUAL_PATH goto SKIPPATH

To take into account this commit: aee741c#virtualenv_support/activate.bat

Do not hesitate to contact me if you need more details.

Thanks!

-- Dominic.

@raidsan
Copy link

raidsan commented Jun 26, 2011

better change to :
if defined _OLD_VIRTUAL_PATH set PATH=%_OLD_VIRTUAL_PATH% && goto SKIPPATH

@piotr-dobrogost
Copy link

Better yet use extended syntax for set :)
Fixed in pull #352
@pypa Should be closed.

@qwcode qwcode closed this as completed Jan 19, 2013
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants