Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20b1 feedback: Unable to generate bash "activate" script on Windows. #1527

Closed
vphilippon opened this issue Jan 29, 2020 · 4 comments
Closed

20b1 feedback: Unable to generate bash "activate" script on Windows. #1527

vphilippon opened this issue Jan 29, 2020 · 4 comments

Comments

@vphilippon
Copy link
Member

@vphilippon vphilippon commented Jan 29, 2020

Hello!

Working on Windows 10, using Git Bash as my default shell pretty much everywhere.

From my understanding, the bash activation script is not generated by default on Windows anymore.
That's going to break users in a similar solution to mine.

But the really bad news for me:

$ python -m virtualenv --activators bash myvirtualenv
usage: virtualenv [--version] [-v | -q] [--discovery {builtin}] [-p py] [--creator {builtin,cpython2-win}] [--seeder {app-data,none,pip}] [--without-pip] [--activators comma_separated_list]
virtualenv: error: argument --activators: the following activators are not available bash

bash is considered not available on Windows, and that's a no-go for me, or anyone using a bash equivalent on Windows.

I'd plead for keeping bash script by default on Windows.
Or at the very least, allow it as an option, although its still going to be a pain.

Cheers!

@gaborbernat

This comment has been minimized.

Copy link
Contributor

@gaborbernat gaborbernat commented Jan 29, 2020

Does anyone have any idea how we can check if bash is available on Windows?

@gaborbernat

This comment has been minimized.

Copy link
Contributor

@gaborbernat gaborbernat commented Jan 29, 2020

Though maybe we should generate both bash and fish by default all the time 🤷‍♂ https://fishshell.com/ seems to be also available on all platforms.

@vphilippon

This comment has been minimized.

Copy link
Member Author

@vphilippon vphilippon commented Jan 31, 2020

FYI I tested the top of the rewrite branch and the bash script is present and working on Windows so far.

Thanks!

@gaborbernat

This comment has been minimized.

Copy link
Contributor

@gaborbernat gaborbernat commented Jan 31, 2020

Thanks for testing, we run the bash test on windows too so we should be good going ahead.

@gaborbernat gaborbernat closed this Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.