Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate VCS ignores to avoid version controlling virtual environments #1806

Closed
gaborbernat opened this issue May 3, 2020 · 3 comments · Fixed by #1825
Closed

Generate VCS ignores to avoid version controlling virtual environments #1806

gaborbernat opened this issue May 3, 2020 · 3 comments · Fixed by #1825

Comments

@gaborbernat
Copy link
Contributor

@gaborbernat gaborbernat commented May 3, 2020

As per https://twitter.com/metalikus/status/1256853693153947649

List of VCSs targeted is https://www.python.org/dev/peps/pep-0610/#registered-vcs

@SanketDG
Copy link

@SanketDG SanketDG commented May 3, 2020

I would like to take this up, where would be this best placed?

def run(self):
if self.dest.exists() and self.clear:
logging.debug("delete %s", self.dest)
safe_delete(self.dest)
self.create()
self.set_pyenv_cfg()

Is something like self._write_gitignore/self._ensure_gitignore after self.set_pyenv_cfg() be a good way to implement this?

@gaborbernat
Copy link
Contributor Author

@gaborbernat gaborbernat commented May 3, 2020

Yeah somewhere there 🤔

@gaborbernat gaborbernat changed the title Generate .gitignore to avoid version controlling virtual environments Generate VCS ignores to avoid version controlling virtual environments May 4, 2020
@gaborbernat
Copy link
Contributor Author

@gaborbernat gaborbernat commented May 20, 2020

This now has been released via https://virtualenv.pypa.io/en/latest/changelog.html#v20-0-21-2020-05-20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants