Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ValueError when unpacking #2165

Merged
merged 2 commits into from
Aug 9, 2021
Merged

fix ValueError when unpacking #2165

merged 2 commits into from
Aug 9, 2021

Conversation

denismaciel
Copy link
Contributor

@denismaciel denismaciel commented Aug 9, 2021 •
edited
Loading

Fixes #2163.

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint) I could not run the linter since tox seems to rely on virtualenv itself, which doesn't work at the moment at my system.
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

gaborbernat
gaborbernat approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat
Copy link
Contributor

Can you please add a changelog entry?

@denismaciel
Copy link
Contributor Author

@gaborbernat I hope I added the changelog entry correctly. I can't currently install tox and pre-commit to validate my changes locally, because they both seem to depend on virtualenv.

@gaborbernat gaborbernat merged commit 3f231f2 into pypa:main Aug 9, 2021
@gaborbernat
Copy link
Contributor

Release going out via https://github.com/pypa/virtualenv/actions/runs/1112888221

gdubicki pushed a commit to gdubicki/virtualenv that referenced this pull request Sep 18, 2021
@denismaciel @gdubicki
fix ValueError when unpacking (pypa#2165)
73df36c
BenMMcLean pushed a commit to TechlauncherFireApp/backend that referenced this pull request Sep 12, 2023
@dependabot
Bump virtualenv from 20.4.4 to 20.8.1 (#103)
deb8f72 
Bumps [virtualenv](https://github.com/pypa/virtualenv) from 20.4.4 to
20.8.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pypa/virtualenv/blob/main/docs/changelog.rst">virtualenv's
changelog</a>.</em></p>
<blockquote>
<h2>v20.8.1 (2021-09-24)</h2>
<p>Bugfixes - 20.8.1</p>
<pre><code>- Fixed a bug where while creating a venv on top of an
existing one, without cleaning, when seeded
wheel version mismatch occurred, multiple ``.dist-info`` directories may
be present, confounding entrypoint
discovery - by :user:`arcivanov`
(`[#2185](pypa/virtualenv#2185)
&lt;https://github.com/pypa/virtualenv/issues/2185&gt;`_)
- Bump embed setuptools from ``58.0.4`` to ``58.1.0`` - by
:user:`gaborbernat`.
(`[#2195](pypa/virtualenv#2195)
&lt;https://github.com/pypa/virtualenv/issues/2195&gt;`_)
<p>Misc - 20.8.1</p>
<pre><code>- `[#2189](pypa/virtualenv#2189)
&amp;lt;https://github.com/pypa/virtualenv/issues/2189&amp;gt;`_


v20.8.0 (2021-09-16)
--------------------

* upgrade embedded setuptools to ``58.0.4`` from ``57.4.0`` and pip to
``21.2.4`` from ``21.2.3``
* Add nushell activation script

v20.7.2 (2021-08-10)
--------------------

Bugfixes - 20.7.2
&lt;/code&gt;&lt;/pre&gt;
&lt;ul&gt;
&lt;li&gt;Upgrade embedded pip to &lt;code&gt;21.2.3&lt;/code&gt; from
&lt;code&gt;21.2.2&lt;/code&gt; and wheel to
&lt;code&gt;0.37.0&lt;/code&gt; from &lt;code&gt;0.36.2&lt;/code&gt; -
by :user:&lt;code&gt;gaborbernat&lt;/code&gt;.
(&lt;code&gt;[#2168](pypa/virtualenv#2168)
&amp;lt;https://github.com/pypa/virtualenv/issues/2168&amp;gt;&lt;/code&gt;_)&lt;/li&gt;
&lt;/ul&gt;
&lt;h2&gt;v20.7.1 (2021-08-09)&lt;/h2&gt;
&lt;p&gt;Bugfixes - 20.7.1&lt;/p&gt;
&lt;pre&gt;&lt;code&gt;- Fix unpacking dictionary items in
PythonInfo.install_path
(`[#2165](pypa/virtualenv#2165)
&amp;lt;https://github.com/pypa/virtualenv/issues/2165&amp;gt;`_)


v20.7.0 (2021-07-31)
--------------------

Bugfixes - 20.7.0
&lt;/code&gt;&lt;/pre&gt;
&lt;ul&gt;
&lt;li&gt;upgrade embedded pip to &lt;code&gt;21.2.2&lt;/code&gt; from
&lt;code&gt;21.1.3&lt;/code&gt; and setuptools to
&lt;code&gt;57.4.0&lt;/code&gt; from &lt;code&gt;57.1.0&lt;/code&gt; -
by :user:&lt;code&gt;gaborbernat&lt;/code&gt;
(&lt;code&gt;[#2159](pypa/virtualenv#2159)
&amp;lt;https://github.com/pypa/virtualenv/issues/2159&amp;gt;&lt;/code&gt;_)&lt;/li&gt;
&lt;/ul&gt;
&lt;p&gt;Deprecations and Removals - 20.7.0&lt;/p&gt;
&lt;pre&gt;&lt;code&gt;- Removed ``xonsh`` activator due to this
breaking fairly often the CI and lack of support from those packages
maintainers, upstream is encouraged to continue supporting the project
as a
`plugin &amp;lt;https://github.com/xonsh/xonsh/issues/3689&amp;gt;`_ -
by :user:`gaborbernat`.
(`[#2160](pypa/virtualenv#2160)
&amp;lt;https://github.com/pypa/virtualenv/issues/2160&amp;gt;`_)

&amp;lt;/tr&amp;gt;&amp;lt;/table&amp;gt; 
&lt;/code&gt;&lt;/pre&gt;
&lt;/blockquote&gt;
&lt;p&gt;... (truncated)&lt;/p&gt;
&lt;/details&gt;
&lt;details&gt;
&lt;summary&gt;Commits&lt;/summary&gt;

&lt;ul&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@433840821a5d2a2308eb84a53bac95efdfacbe7c&quot;&gt;&lt;code&gt;4338408&lt;/code&gt;&lt;/a&gt;
release 20.8.1&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@e13ea2a7c65f233df0bc526ae073c01747258de8&quot;&gt;&lt;code&gt;e13ea2a&lt;/code&gt;&lt;/a&gt;
During seeding properly uninstall present versions of the wheels (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2186&quot;&gt;#2186&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@3b9d95481a7bb8ce98bc3118416ba6cbbedf99b4&quot;&gt;&lt;code&gt;3b9d954&lt;/code&gt;&lt;/a&gt;
Bump embed setuptools to 58.1.0 (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2195&quot;&gt;#2195&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@40d2f1833bab94fa2cad852c5b9e31d42c66d570&quot;&gt;&lt;code&gt;40d2f18&lt;/code&gt;&lt;/a&gt;
Fail early instead of creating non-working env (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2189&quot;&gt;#2189&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@9e03c945fbf22cb1384d944f874180292c1018d4&quot;&gt;&lt;code&gt;9e03c94&lt;/code&gt;&lt;/a&gt;
[pre-commit.ci] pre-commit autoupdate (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2192&quot;&gt;#2192&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@2151d385094c4f320cd2484eb9bcf3272cea2cc3&quot;&gt;&lt;code&gt;2151d38&lt;/code&gt;&lt;/a&gt;
Improve prompt nushell (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2190&quot;&gt;#2190&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@d810ce1c0613d1b955576bca644335b7a00b5bc0&quot;&gt;&lt;code&gt;d810ce1&lt;/code&gt;&lt;/a&gt;
Merge pull request &lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2184&quot;&gt;#2184&lt;/a&gt;
from pypa/release-20.8.0&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@c54c7efe172adb206c75cc1499cf8625b19064e8&quot;&gt;&lt;code&gt;c54c7ef&lt;/code&gt;&lt;/a&gt;
release 20.8.0&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@e0410cafc8feedf72562174dee983fc709a5a36e&quot;&gt;&lt;code&gt;e0410ca&lt;/code&gt;&lt;/a&gt;
Nushell activation scripts (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2170&quot;&gt;#2170&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;&lt;a
href=&quot;pypa/virtualenv@1cc503bfadc2c0e8c3ecac6c0a3f430ee601d9a0&quot;&gt;&lt;code&gt;1cc503b&lt;/code&gt;&lt;/a&gt;
Bump pip and setuptools (&lt;a
href=&quot;https://redirect.github.com/pypa/virtualenv/issues/2183&quot;&gt;#2183&lt;/a&gt;)&lt;/li&gt;
&lt;li&gt;Additional commits viewable in &lt;a
href=&quot;pypa/virtualenv@20.4.4...20.8.1&quot;&gt;compare
view&lt;/a&gt;&lt;/li&gt;
&lt;/ul&gt;
&lt;/details&gt;

&lt;br /&gt;
</code></pre>


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=virtualenv&package-manager=pip&previous-version=20.4.4&new-version=20.8.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ValueError: too many values to unpack (expected 2)" when running python3 -m virtualenv xxx -p python3.8
2 participants
@denismaciel @gaborbernat