Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for pip distribution does not work as documented #316

Closed
andreiko opened this issue Aug 17, 2012 · 2 comments
Closed

Search for pip distribution does not work as documented #316

andreiko opened this issue Aug 17, 2012 · 2 comments

Comments

@andreiko
Copy link

Documentation on "--never-download" says:

If this option is provided, virtualenv will never try to download setuptools/distribute or pip. Instead, it will exit with status code 1 if it fails to find local distributions for any of these required packages. The local distribution lookup is done in this order and the following locations:

  1. The current directory.
  2. The directory where virtualenv.py is located.
  3. A virtualenv_support directory relative to the directory where virtualenv.py is located.
  4. If the file being executed is not named virtualenv.py (i.e. is a boot script), a virtualenv_support directory relative to wherever virtualenv.py is actually installed.

I understand this as "the first match is used for installation".

In the beginning install_pip function filenames list is generated with respect to that order, but then in gets sorted by basename and the last filename from that list is used no matter from what location it came from.

Why do we need that sort at all?

@carljm
Copy link

carljm commented Aug 24, 2012

The purpose of the sort is to install the most recent version of pip found in any of the checked locations. It could be debated whether this is the best policy, but changing it would be a backwards-compatibility problem, so a very strong case would need to be made that it is worth changing.

I agree that the docs could use clarification on that point.

@stale
Copy link

stale bot commented Jan 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Just add a comment if you want to keep it open. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 15, 2019
@stale stale bot closed this as completed Jan 22, 2019
@pypa pypa locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants