Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dropdowns #3194

Closed
nlhkabu opened this issue Mar 9, 2018 · 5 comments · Fixed by #3287
Closed

Refactor dropdowns #3194

nlhkabu opened this issue Mar 9, 2018 · 5 comments · Fixed by #3287
Assignees
@nlhkabu
Labels
accessibility Issues with accessibility or to improve accessibility bug 🐛 CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files
Projects
Warehouse rollout
Milestone
5: Shut Down Lega...

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Mar 9, 2018

To make the dropdowns keyboard accessible, we should follow this guide: https://www.w3.org/WAI/tutorials/menus/flyout/

At the same time, we should fix a bug we found - that sometimes the dropdown are being cut off:

screenshot from 2018-03-09 06-14-28

ping @alexwlchan - could you please post your screenshots here? Thx
@nlhkabu nlhkabu added accessibility Issues with accessibility or to improve accessibility HTML requires change to HTML files CSS/SCSS requires change to CSS/SCSS files bug 🐛 user testing labels Mar 9, 2018
@nlhkabu nlhkabu self-assigned this Mar 9, 2018
@nlhkabu nlhkabu added this to the 3: Publicize beta milestone Mar 11, 2018
@alexwlchan
Copy link
Contributor

alexwlchan commented Mar 13, 2018 •
edited

Here’s a couple more screenshots from our user testing session last Thursday. Browser is Safari 11.0.2 on macOS 10.12.6.

screen shot 2018-03-08 at 06 38 41

screen shot 2018-03-08 at 07 13 39

screen shot 2018-03-08 at 07 14 21

@brainwane
Copy link
Contributor

@nlhkabu About how hard is this to fix -- that is to say, do you think you can fix it this week? I'm trying to figure out when we are going to announce the beta.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 15, 2018

@brainwane - I'm a bit behind on this one. Starting tonight. I imagine we could have it merged by early next week.

@nlhkabu nlhkabu mentioned this issue Mar 16, 2018
Merged
@brainwane brainwane added this to Milestone 5: Shut Down Legacy PyPI in Warehouse rollout Mar 21, 2018
@brainwane brainwane moved this from Milestone 5: Shut Down Legacy PyPI to Milestone 3: Publicize beta in Warehouse rollout Mar 21, 2018
@di di moved this from Milestone 3: Publicize beta to In Progress in Warehouse rollout Mar 21, 2018
@brainwane brainwane mentioned this issue Mar 21, 2018
Closed
@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 22, 2018

@brainwane - this is a little more complex than I initially thought. PR is in progress, but probably won't get merged until next week. To be clear, I don't think this needs to block publicising beta - the current solution we have works - just not for keyboard-only users.

@brainwane brainwane moved this from In Progress to Milestone 5: Shut Down Legacy PyPI in Warehouse rollout Mar 22, 2018
@brainwane
Copy link
Contributor

OK, thanks for the update @nlhkabu, moving to a later milestone!

@di di moved this from Milestone 5: Shut Down Legacy PyPI to In Progress in Warehouse rollout Apr 17, 2018
Warehouse rollout automation moved this from In Progress to Done Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlhkabu nlhkabu

Labels
accessibility Issues with accessibility or to improve accessibility bug 🐛 CSS/SCSS requires change to CSS/SCSS files HTML requires change to HTML files
Projects
No open projects
Warehouse rollout
  
Done
Milestone
5: Shut Down Legacy PyPI
Development

Successfully merging a pull request may close this issue.

Refactor dropdowns to follow WAI recommendations pypi/warehouse
3 participants
@alexwlchan @brainwane @nlhkabu