valid email address deemed invalid

[janwijbrand]

When trying to add an additional email address to my account, the email address is rejected. This email address however /is/ valid. The domain for the email address is n--tree.net. I guess the validator trips over the (admittedly uncommon) double dash in it. Hopefully this can be resolved.

---

Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here, #pypa-dev on Freenode, or the pypa-dev mailing list.

[di]

@janwijbrand Sorry you're having troubles! This seems to be due to one of our dependencies, wtforms, and there isn't really a great way for us to override the behavior.

Would you raise the issue in their tracker instead? https://github.com/wtforms/wtforms/issues. Thanks for the report!

[janwijbrand]

Thanks @di. I've made the report here: wtforms/wtforms#384.

[davidism]

It's absolutely possible to change the validator you're using. Although it's sort of futile to try to validate addresses rather than just sending them. I'd recommend removing the validator, or replacing it with a simpler one. I don't really like to keep changing the email regex, since it never seems to end. I also don't really have time to release a new WTForms version any time soon, although it's on my todo list.

[janwijbrand]

Thanks @davidism for your reply. I hope @di can reopen the issue and followup on your suggestions? The situation is somewhat finicky for me as I really want to update my email address. It is not blocking, but it certainly would be nice. Thanks again.

[di]

@davidism Seems to me like the user https://pypi.org/user/davidism/ is still an Owner of the project https://pypi.org/project/WTForms/, do you not see this project on login?

@janwijbrand Could you email me at di@python.org from the address you'd like to add?

Ultimately removing the validator entirely is blocked on #3632.

[di]

This issue is no longer blocked -- all new emails must be verified before they can be used, so we can remove the wtforms.validators.Email validator and replace it with something much simpler, like wtforms.validators.Regexp(r".+@.+\..+"), which should be good enough to catch most common mistakes.

[davidism]

As a side note, WTForms also moved to using the email_validator library, although I don't think there's going to be a release any time soon. But you might want to look into using it too if you want more thorough validation still.

[robindboer]

With #6013 merged, I think this issue is resolved and can be closed.

[brainwane]

@robindboer Thanks for the fix! Do you have an idea of what you might work on next? If you'd like to keep working on Warehouse and you would like a suggestion, please feel free to comment and ask for one :-)

[robindboer]

@brainwane Would love to continue to work on Warehouse. I was looking for a next issue already but if you have any suggestions, they are welcome. Thanks!

[brainwane]

@robindboer is #5825 something you would be interested in working on?

[brainwane]

Actually @robindboer looks like some of my colleagues want to take care of that in a particular way. Are you potentially interested in learning some ElasticSearch and working on #4006 or one of our other issues tagged "search"?

[robindboer]

@brainwane thanks for the suggestions. I will look into the issues later today and see if I can pick up any of the issues. I have never worked with ES before but I see that as an opportunity 😄 Thanks!

[brainwane]

Thanks, @robindboer - if you're having any trouble, please do feel free to leave a question on the issue, chat with us in IRC in #pypa-dev on Freenode, or ask a question on the pypa-dev mailing list.