Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowners file #4379

Closed
nlhkabu opened this issue Jul 28, 2018 · 3 comments
Closed

Add codeowners file #4379

nlhkabu opened this issue Jul 28, 2018 · 3 comments
Assignees
Labels
developer experience Anything that improves the experience for Warehouse devs

Comments

@nlhkabu
Copy link
Contributor

nlhkabu commented Jul 28, 2018

Allows github to automatically assign reviewers based on ownership areas

Example from CPython:
https://github.com/python/cpython/blob/master/.github/CODEOWNERS

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Jul 29, 2018

I should own / co-own:

  • README.rst
  • docs
  • warehouse/templates
  • warehouse/static/html
  • warehouse/static/sass
  • warehouse/static/images
  • warehouse/admin/templates
  • warehouse/admin/static/css
  • warehouse/admin/static/fonts
  • warehouse/admin/static/img
  • warehouse/admin/static/webfonts

@nlhkabu nlhkabu added the developer experience Anything that improves the experience for Warehouse devs label Jul 29, 2018
@di
Copy link
Member

di commented Apr 3, 2020

@nlhkabu, I agree we should add a CODEOWNERS for you for those files, but I don't think we should add it for the rest of us. I personally tend to treat a pending review as a blocker on merging a PR, and would prefer to keep the "request review" feature as a stronger signal, e.g. "I actually need you specifically to look at this PR."

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Apr 26, 2020

Thanks for your feedback @di. I have been thinking about this -> I don't want to become a blocker to merging a PR if I am unavailable for a time period, so I'm going to close this issue.

In the time I've been working on the project, I can think of very few times I've not been added to review a design/HTML/CSS change, so I am not sure there is a real problem here :)

@nlhkabu nlhkabu closed this as completed Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Anything that improves the experience for Warehouse devs
Projects
None yet
Development

No branches or pull requests

4 participants