Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trove classifiers accordion only open one tab at once #755

Closed
dstufft opened this issue Nov 19, 2015 · 4 comments
Closed

Make trove classifiers accordion only open one tab at once #755

dstufft opened this issue Nov 19, 2015 · 4 comments
Labels
javascript requires change to JavaScript files UX/UI design, user experience, user interface

Comments

@dstufft
Copy link
Member

dstufft commented Nov 19, 2015

Currently you can view more than one section of trove classifiers at one time, for example, both By Environment and By Framework could be open.

Given the potential length of the page, I think we should consider enforcing the closing of other sections when a new one is opened.

@dstufft dstufft added the UX/UI design, user experience, user interface label Nov 19, 2015
@nlhkabu nlhkabu modified the milestone: Become PyPI Dec 12, 2015
@dstufft dstufft modified the milestone: Launch Apr 18, 2016
@nlhkabu nlhkabu modified the milestone: Launch Jun 7, 2016
@brainwane brainwane modified the milestones: 3) Feature parity with PyPI, 2) Launch: redirect pypi.python.org to pypi.io Jun 30, 2016
@nlhkabu nlhkabu modified the milestones: 2: Launch: redirect pypi.python.org to pypi.io, 3: Feature parity with PyPI Jul 1, 2016
@nlhkabu nlhkabu added the javascript requires change to JavaScript files label Jul 1, 2016
@di
Copy link
Member

di commented Aug 17, 2016

I created a branch which fixes this here: dabbdfe...di:fix-755

However, in doing so I noticed that this would introduce an issue with the UI that we probably don't want: Because some of the classifier lists are longer than the viewport, if one of them, such as "By Programming Language", is open:

screen shot 2016-08-17 at 5 59 10 pm
And we scroll to the bottom:

screen shot 2016-08-17 at 6 10 13 pm
When we click "By Development Status", it disappears, because it's much shorter, and the entire list has jumped out of the viewport:

screen shot 2016-08-17 at 6 10 18 pm
I suppose we could address that by additionally forcing a jump to an anchor tag on the category, but I feel like that would be worse UX than what we've got as-is.

@nlhkabu, thoughts?

@nlhkabu
Copy link
Contributor

nlhkabu commented Aug 18, 2016

This is a really difficult problem and I'm not sure that I have a solution.

My gut feeling is to pan the viewport back up to the activated accordion heading ala http://www.stampede-design.com/blog/demo/shaiful/large-accordion/large-accordion-fix.html

In this case, a pan/scroll should be less abrupt than jumping to the position, which might help... although, like you, I'm not sure this will actually be better.

Perhaps the solution then is to be content with allowing multiple accordion sections to be open at once and dropping this issue altogether?

@di
Copy link
Member

di commented Aug 19, 2016

Perhaps the solution then is to be content with allowing multiple accordion sections to be open at once and dropping this issue altogether?

👍 from me.

@nlhkabu
Copy link
Contributor

nlhkabu commented Aug 20, 2016

Ok, given your agreement @di, I am going to close this issue now. :)

@nlhkabu nlhkabu closed this as completed Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript requires change to JavaScript files UX/UI design, user experience, user interface
Projects
None yet
Development

No branches or pull requests

4 participants