Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect authenticated user from reset pw pages to index #2988

Merged

Conversation

hendrikmakait
Copy link
Contributor

Resolves #2802.

@di
Copy link
Member

di commented Feb 20, 2018

Thanks @HndrkMkt! We'll probably want to remove this link as well, since it links to one of these pages for a logged in user.

@hendrikmakait
Copy link
Contributor Author

Hi @di, don't we redirect from that page if the user is logged in as per #2936?

@di
Copy link
Member

di commented Feb 20, 2018

Right, what I mean is that the link is only shown to a logged-in user (on the "manage account" page) and since it will always redirect, we should just remove it, there's no point in having it if a logged-in user can't do a password reset.

@di
Copy link
Member

di commented Feb 26, 2018

Hi @HndrkMkt, does that clarify what I'm asking for in this PR?

@hendrikmakait hendrikmakait force-pushed the 2802-redirect-authenticated-user-from-pw-reset branch from 639a21e to 34d3932 Compare February 26, 2018 16:20
@hendrikmakait
Copy link
Contributor Author

Hi @di, sorry for the late reply. I checked the link you provided and as far as I can tell that page is shown if you want to login to the page. Did you mean this one by any chance? That should be the one displayed on the "manage account" page.

@di
Copy link
Member

di commented Feb 26, 2018

Ah, you're absolutely right @HndrkMkt, good catch. Yes that's the one that should be removed. Sorry for the confusion!

@hendrikmakait
Copy link
Contributor Author

No problem :) I removed the link in my last commit.
In case there's some other issues you'd recommend working on next, please let me know!

@di di merged commit a84d09f into pypi:master Feb 26, 2018
@di
Copy link
Member

di commented Feb 26, 2018

Thanks @HndrkMkt! I'll let @brainwane direct you towards other potential areas for contribution.

@brainwane
Copy link
Contributor

@HndrkMkt thanks for your contribution! I'm going to list here a few issues that I think may be good ones for you to work on, based on this PR and other work you've done.

Go ahead and comment on any one of them to say you're working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants