-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect authenticated user from reset pw pages to index #2988
Redirect authenticated user from reset pw pages to index #2988
Conversation
Thanks @HndrkMkt! We'll probably want to remove this link as well, since it links to one of these pages for a logged in user. |
Right, what I mean is that the link is only shown to a logged-in user (on the "manage account" page) and since it will always redirect, we should just remove it, there's no point in having it if a logged-in user can't do a password reset. |
Hi @HndrkMkt, does that clarify what I'm asking for in this PR? |
639a21e
to
34d3932
Compare
Ah, you're absolutely right @HndrkMkt, good catch. Yes that's the one that should be removed. Sorry for the confusion! |
No problem :) I removed the link in my last commit. |
Thanks @HndrkMkt! I'll let @brainwane direct you towards other potential areas for contribution. |
@HndrkMkt thanks for your contribution! I'm going to list here a few issues that I think may be good ones for you to work on, based on this PR and other work you've done.
Go ahead and comment on any one of them to say you're working on it! |
Resolves #2802.