Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default text to browse page #3327

Merged
merged 4 commits into from
Mar 21, 2018
Merged

Add default text to browse page #3327

merged 4 commits into from
Mar 21, 2018

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Mar 21, 2018

Closes #3062

screenshot from 2018-03-21 07-04-34

Includes:

  • Small restyle of the filter buttons (to give them more room)
  • Adjustment of results message to reflect applied filters, examples:

Search only

screenshot from 2018-03-21 07-07-36

Classifiers only

screenshot from 2018-03-21 07-07-00
screenshot from 2018-03-21 07-06-53

Search and classifiers

screenshot from 2018-03-21 07-08-07

<p>Enter a search query above, or select a filter from the list of classifiers on the left.</p>
<p>You can combine searches and classifier filters. Examples:</p>
<ul class="no-bottom-margin">
<li><a href="/search/?q=&o=&c=Programming+Language+%3A%3A+Python+%3A%3A+3">New Python 3 project releases</a></li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure the best way to make these examples - so I've just hardcoded them for now :/
could someone please advise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured it was easier to "show" than "tell" so I fixed this in 16423df, take a look. 🙂

@nlhkabu nlhkabu added the help needed We'd love volunteers to advise on or help fix/implement this. label Mar 21, 2018
@di di force-pushed the show-message-when-no-search branch from 86b8190 to 9dfab1d Compare March 21, 2018 17:13
@di di merged commit 29ec814 into master Mar 21, 2018
@di di deleted the show-message-when-no-search branch March 21, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help needed We'd love volunteers to advise on or help fix/implement this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants