Reindex as celery task #3459
Merged
Reindex as celery task #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewdurbin
commented
Mar 28, 2018
warehouse/cli/search.py
Outdated
| Recreate the Search Index. | ||
| """ | ||
|
|
||
| config.task(_reindex).apply_async() |
There was a problem hiding this comment.
@dstufft I couldn't figure out how to get this to run "in the foreground".
I tried wrapping apply() in a way similar to warehouse.tasks:WarehouseTask.apply_async() but kept getting transaction.interfaces.NoTransaction
There was a problem hiding this comment.
runs great on the worker though!
There was a problem hiding this comment.
You probably have to do some setup to get the request in a reasonable state.
ewdurbin
force-pushed
the
reindex_as_celery_task
branch
from
03ca2b1
to
1dd04bc
Compare
ewdurbin
force-pushed
the
reindex_as_celery_task
branch
from
1dd04bc
to
0f7bc49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this runs in ~1minute now... may as well make it a celery task and update it every 3 hours instead of nightly :)