Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text about classifier position #3477

Merged
merged 2 commits into from
Mar 31, 2018
Merged

Fix text about classifier position #3477

merged 2 commits into from
Mar 31, 2018

Conversation

nlhkabu
Copy link
Contributor

@nlhkabu nlhkabu commented Mar 30, 2018

Closes #3454

screenshot from 2018-03-30 12-49-02
screenshot from 2018-03-30 12-48-49

@nlhkabu nlhkabu requested a review from brainwane March 30, 2018 17:19
brainwane
brainwane approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@brainwane brainwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, this feels like magic. :) Works for me on desktop; I haven't checked mobile.

@nlhkabu
Copy link
Contributor Author

nlhkabu commented Mar 31, 2018

Mobile will work the same as desktop - as it is based off resolution rather than device :)

@nlhkabu nlhkabu merged commit e8c2ee6 into master Mar 31, 2018
@nlhkabu nlhkabu deleted the 3454-text-classifier-positions branch March 31, 2018 14:58
nitinprakash96 pushed a commit to nitinprakash96/warehouse that referenced this pull request Mar 31, 2018
@nlhkabu @nitinprakash96
Fix text about classifier position (pypi#3477)
0a881cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainwane brainwane brainwane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlhkabu @brainwane