Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email notification when a role is changed/removed #8328

Merged
merged 10 commits into from Aug 4, 2020

Conversation

patelneel55
Copy link
Contributor

Sends an email to the project owners and the associated user when a role is changed or removed. Closes #3264

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few changes. We also need to remove all {% trans %} tags from the email templates, since the locale of the user initiating them is not necessarily the same as the recipient (see #7583)

warehouse/manage/views.py Show resolved Hide resolved
warehouse/manage/views.py Show resolved Hide resolved
warehouse/manage/views.py Show resolved Hide resolved
warehouse/manage/views.py Show resolved Hide resolved
warehouse/manage/views.py Show resolved Hide resolved
@di di merged commit 6ac95a3 into pypi:master Aug 4, 2020
@patelneel55 patelneel55 deleted the send_role_change_email branch August 7, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email notification for demoted/removed user
2 participants