fix: remove warning on 3.12a7+ #529
Conversation
|
Please add a news item too. |
henryiii
force-pushed
the
henryiii/fix/312warn
branch
from
00a1ffb
to
e1086f5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 70.02% 70.20% +0.17%
==========================================
Files 13 13
Lines 1071 1074 +3
==========================================
+ Hits 750 754 +4
+ Misses 321 320 -1
☔ View full report in Codecov by Sentry. |
|
Should we perhaps add a test for the callback? I know we didn't have one, but if you feel inclined to add one, that would be wonderful. It's not a showstopper though. |
|
I'll look into it soon! PyCon might get in the way of doing it promptly. |
henryiii
force-pushed
the
henryiii/fix/312warn
branch
3 times, most recently
from
76b08ca
to
d4e443f
Compare
src/wheel/bdist_wheel.py
Outdated
|
|
||
|
|
||
| def remove_readonly_exc(func, path, exc): | ||
| print(str(exc)) |
There was a problem hiding this comment.
This prints to stdout. Shouldn't it print to stderr instead?
There was a problem hiding this comment.
I'm not sure it should print anything at all. In all likelihood this was a leftover debugging line.
|
FYI, there is a way to set patch coverage to 'informational' to get it to report on the diff, but not put a red x if an uncovered line is added or changed. Let me know if you are interested in me adding that. :) |
|
@agronholm, any comments? |
Yes, please. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/fix/312warn
branch
from
d4e443f
to
fd2bbd7
Compare
src/wheel/bdist_wheel.py
Outdated
|
|
||
|
|
||
| def remove_readonly_exc(func, path, exc): | ||
| print(str(exc)) |
There was a problem hiding this comment.
I'm not sure it should print anything at all. In all likelihood this was a leftover debugging line.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
There's a new checkbox checked by default: [ ] Wait for successful checks. If that's checked, the |
|
I've never seen that. Are you using Refined-github? A search shows refined-github/refined-github#1771. But it doesn't look like that, it's integrated in to the button. GitHub's built-in feature is based on branch protections (and ideally, a "pass" job). |
|
Yeah, must be that. I completely forgot that I still had that extension. |
|
Any plans for a patch release? It would be nice to have this warning fix & the build "number" fix. :) |
|
Done. |
Removing warning on 3.12 alphas. Closes #526.
This drops support for the early 3.12 alphas, but older alphas aren't usually actively supported anyway. LMK if they need support too.