Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings UI use OpenPype styles #2296

Merged
merged 50 commits into from
Nov 30, 2021

Conversation

iLLiCiTiT
Copy link
Member

Goal

Setting UI should use OpenPype styles instead of having it's own.

Changes

  • local settings and studio settings use openpype's stylesheet
  • most of settings stylesheet copied to openpype stylesheet
    • not all are same
  • most of buttons in settings have real image instead of using characters
    • their size is based on font size
  • use new checkbox which has size defined by font size
    • few fixes in new checkbox

Note

If anything is so different that is' bad tell me in comments.

@mkolar
Copy link
Member

mkolar commented Nov 23, 2021

Task linked: OP-1775 Settings UI use openpype styles

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 23, 2021
@iLLiCiTiT iLLiCiTiT added the type: feature Larger, user affecting changes and completely new things label Nov 23, 2021
@mkolar
Copy link
Member

mkolar commented Nov 24, 2021

I made a small comparison screen and have some comments
image

  • +- buttons are a bit too heavy and prominent. If possible we should make them a bit lighter or possibly smaller so they don't - should as much
  • list arrows are very imbalanced as well. heavy and the actual arrows are not centered to the circles.
  • What's up with the gradient on checkbox hover :)? flat colours everywhere and a rogue gradient suddenly. Let's go with the same principle as elsewhere with slight colour shift on hover pls.
  • darken the section headers a bit. They are practically white now compared to before. Better contrast, but a bit too much and it market hover highlight practically inverted (darker on highlight)

Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in comment above

@iLLiCiTiT
Copy link
Member Author

Modified icon images
image

@iLLiCiTiT
Copy link
Member Author

Modified colors of checkbox
image

@iLLiCiTiT
Copy link
Member Author

Current state. Left: Previous - Right: this PR
image

Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks as it is shown in your last screenshot (beautiful - if you asked me ;)

@iLLiCiTiT iLLiCiTiT merged commit ba28553 into develop Nov 30, 2021
@iLLiCiTiT iLLiCiTiT deleted the feature/OP-1775_Settings-UI-use-openpype-styles branch December 13, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Larger, user affecting changes and completely new things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants