Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aftereffects: New style validations for New publisher #2430

Merged
merged 4 commits into from Dec 22, 2021
Merged

Aftereffects: New style validations for New publisher #2430

merged 4 commits into from Dec 22, 2021

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Dec 22, 2021

Brief description

New Publisher expects a bit different styles of validators. (Using our own validator exception instead of asserts.)

Description

This PR modifies validators for Photoshop

Testing notes:

  1. Enable availability of New Publisher in your Local Settings
  2. Try New Publisher in AfterEffects, try to mess with scene to trigger validations.

@kalisp kalisp added type: enhancement Enhancements to existing functionality host: After Effects labels Dec 22, 2021
@kalisp kalisp requested a review from 64qam December 22, 2021 09:02
@kalisp kalisp self-assigned this Dec 22, 2021
@kalisp kalisp changed the base branch from develop to feature/validation_exceptions December 22, 2021 12:18
@kalisp kalisp merged commit 6fe72b6 into feature/validation_exceptions Dec 22, 2021
@kalisp kalisp deleted the feature/validation_exceptions_aftereffects branch December 22, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

Assignees

@kalisp kalisp

Labels
host: After Effects type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalisp @64qam