Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftrack: Use ApplicationManager to get DJV path #2558

Merged
merged 1 commit into from Jan 19, 2022
Merged

Ftrack: Use ApplicationManager to get DJV path #2558

merged 1 commit into from Jan 19, 2022
+81 −25

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Current DJV action is looking for DJV path into env variable DJV_PATH but we have DJV in system settings.

Changes

  • DJV action is using ApplicationManager to get path to DJV
  • action will offer to choose from available djv versions if there are more

Testing notes:

  1. Set path to DJV in settings
  2. Try to run the action it on Asset Version that has components with full path

@iLLiCiTiT iLLiCiTiT self-assigned this Jan 19, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Jan 19, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> [ Application "DJV View" - Registered successfully (0.0022sec) ]

@iLLiCiTiT iLLiCiTiT merged commit 7afc0e8 into develop Jan 19, 2022
@mkolar mkolar deleted the bugfix/frack_djv_view_action_fix branch January 24, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam Awaiting requested review from 64qam

@antirotor antirotor Awaiting requested review from antirotor

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @m-u-r-p-h-y