Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tools: Don't use avalon tools code #2829

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Tools: Don't use avalon tools code #2829

merged 6 commits into from
Mar 3, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Planned movement of code requires to cleanup code in openpype first. One change is that

Description

Changed imports to not use lib functions and models from avalon.tools but from openpype.tools.utils.

Changes

  • changed imports
  • moved pyblish gui discover logic into openpype

Testing notes:

Nothing should change. Affected places:

  • Standalone publishing should show publish tool
  • Scene inventory should display versions correctly
  • Maya should have pyblish icon in menu
  • mayalookassigner should work before
  • workfiles tool should work as before

@mkolar
Copy link
Member

mkolar commented Mar 2, 2022

Task linked: OP-2814 Use openpype tools only

@iLLiCiTiT iLLiCiTiT self-assigned this Mar 2, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Mar 2, 2022
@mkolar mkolar self-requested a review March 2, 2022 14:22
mkolar
mkolar approved these changes Mar 3, 2022
View reviewed changes
Copy link
Member

@mkolar mkolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to work all fine for me

@mkolar mkolar added type: refactor Structural changes not affecting functionality and removed type: enhancement Enhancements to existing functionality labels Mar 3, 2022
@BigRoy
Copy link
Collaborator

BigRoy commented Mar 3, 2022

Should we also refactor this comment?

@iLLiCiTiT
Copy link
Member Author

Should we also refactor this comment?

I've asked and the harmony plugin is installed automatically. I've removed the backwards compatibility.

@iLLiCiTiT iLLiCiTiT merged commit e7450ef into develop Mar 3, 2022
@iLLiCiTiT iLLiCiTiT deleted the enhancement/OP-2814_Use-openpype-tools-only branch March 3, 2022 14:42
@mkolar mkolar added this to the 3.9.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy left review comments

@mkolar mkolar mkolar approved these changes

@antirotor antirotor Awaiting requested review from antirotor

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @mkolar @BigRoy