Standalone: settings improvements #3355
Merged
+78
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64qam
approved these changes
Jun 16, 2022
64qam
requested changes
Jun 17, 2022
|
I have merged actual develop branch - expecting that problem was in a bug living in developing at the time. |
|
Still the same issue even on the new project |
|
@iLLiCiTiT could you please have a look? Maybe you'll shed some light here, while Jakub is on holiday |
|
Issue of this is that review instances have only one representation which should not be integrated but IntegrateAssetNew don't care about it and find it out too late. Created separated PR as it's not directly connected to this issue #3398. |
64qam
approved these changes
Jun 23, 2022
…before_integration_start General: Filter representations before integration start
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| if "delete" in repre.get("tags", []): | ||
| continue | ||
|
|
||
| for idx, repre in enumerate(repres): |
There was a problem hiding this comment.
Loop control variable 'idx' not used within the loop body. If this is intended, start the name with an underscore.
| @@ -158,7 +192,7 @@ def process(self, instance): | |||
| self.handle_destination_files(self.integrated_file_sizes, 'remove') | |||
| six.reraise(*sys.exc_info()) | |||
|
|
|||
| def register(self, instance): | |||
| def register(self, instance, repres): | |||
There was a problem hiding this comment.
'IntegrateAssetNew.register' is too complex (52)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Added missing settings for shot rename switch
Description
Additional info
For testing of simple editorial publishing use this files
Testing notes:
project_settings/standalonepublisher/publish/CollectHierarchyInstance/shot_add_hierarchy/enabledto False.editorialfamily