General: Use query functions in rest api calls #3457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-3410 Use query functions in avalon module |
64qam
approved these changes
Jul 1, 2022
iLLiCiTiT
deleted the
feature/OP-3410_Use-query-functions-in-avalon-module
branch
BigRoy
reviewed
Jul 1, 2022
Comment on lines
+25
to
+28
| output = [ | ||
| project_doc | ||
| for project_doc in get_projects() | ||
| ] |
There was a problem hiding this comment.
Is there a reason this isn't just output = list(get_projects())?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Rest api calls in avalon module use query functions instead of
AvalonMongoDB.Additional info
Not sure if are the rest points used anywhere? Maybe we could removed them.
Testing notes:
It should be possible to receive project documents using rest api points. Try access
http://localhost:8079/avalon/projectswhen tray is running.