Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maya + Yeti: Load Yeti Cache fix frame number recognition #3942

Merged
merged 1 commit into from Oct 10, 2022

Conversation

BigRoy
Copy link
Collaborator

@BigRoy BigRoy commented Oct 5, 2022

Brief description

Previously a cache starting at frame 1005 would fail due to a "5" being present. This would only be noticable if the start frame used for detection included a digit that was not 0, 1, 2, 3 or 4. I guess we've had the luck to always have been starting with a frame number like 1001, 1000, etc. because if any number in 56789 would have been present then this would previously fail.

Description

It's funny how long this must have been missed. We've been so lucky!
Looks like I introduced this bug five months ago. 🗡️

Testing notes:

  1. Publish a yeti cache with 5, 6, 7, 8 or 9 in the frame number (e.g. single frame at frame 1005)
  2. Load yeti cache should work.

- Previously 1005 would fail due to a "5" being present. This would only be noticable if the start frame used for detection included a digit that was not 0, 1, 2, 3 or 4.
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a test with publishing just frame 1005. All went smoothly and later loaded well into shot scene as yeti single frame cache.

So its working fine.

@mkolar mkolar merged commit b84d684 into ynput:develop Oct 10, 2022
@BigRoy BigRoy deleted the maya_yeti_fix_load_cache_frame branch March 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants