Maya: Set default value for RenderSetupIncludeLights option

[antirotor]

Fix

RenderSetupIncludeLights must be either set to 1 or 0 or not at all. This PR is adding default value for edge cases where this is not handled. Without it, DL is crashing.

[m-u-r-p-h-y]

submitted Maya render with old render instance with missing Render Setup Include Lights attribute.

Deadline job has the attribute in job properties with value 1 so Deadline wont crash anymore.

The question is, if we are really assigning default value from project settings

[m-u-r-p-h-y]

another question is, for cases with the missing attribute on the instance and in settings, if the "safer" default value should be 0 instead of 1

[antirotor]

another question is, for cases with the missing attribute on the instance and in settings, if the "safer" default value should be 0 instead of 1

I think it should follow Maya default and that is 1. Added code to pull default value from the Settings.

[BigRoy]

This .get().get().get() feels wrong. As soon as one of the keys doesn't exist it'd be None and doing .get() would fail. So it's just as prone to error as just doing ["project_settings"]["maya"]["RenderSettings"]["enable_all_lights"]

Also the fallback down below to the default value could thus still fall back to "None" otherwise if enable_all_lights wouldn't exist.

[antirotor]

you are right, I've just copy&pasted it from somewhere. I guess it was like that because of readability but that is questionable anyway.

[m-u-r-p-h-y]

I think it should follow Maya default and that is 1. Added code to pull default value from the Settings.

that's exactly what I meant. I thought our default 0 is Maya's default. You are correct it is 1, so we should change our defaults in openpype\settings\defaults\project_settings\maya.json to 1 to follow Maya's default value.

[m-u-r-p-h-y]

It is correctly assigning the value from project settings, in case the value is missing on render instance,