Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Fix deprecated warning in legacy creator #3978

Merged
merged 1 commit into from Oct 14, 2022
Merged

General: Fix deprecated warning in legacy creator #3978

merged 1 commit into from Oct 14, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Fixed import of 'get_subset_name' function in LegacyCreator.

Description

Function get_subset_name was moved from openpype.lib to openpype.pipeline.create and modified arguments. This PR is using new function location and is handling different arguments.

Warning message

PluginToolsDeprecatedWarning: Call to deprecated function 'get_subset_name'
Function was moved or removed. Please check content of deprecated function to figure out possible replacement.

Testing notes:

  1. Deprecation warning should not be printed when LegacyCreator is used to create instance in scene

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 13, 2022
@iLLiCiTiT iLLiCiTiT added the type: refactor Structural changes not affecting functionality label Oct 13, 2022
kalisp
kalisp approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Message is not printed anymore, creator works(in AE).

@iLLiCiTiT iLLiCiTiT merged commit 8bf63ef into develop Oct 14, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/get_subset_name_import_fix branch October 14, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalisp kalisp kalisp approved these changes

@64qam 64qam Awaiting requested review from 64qam

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: refactor Structural changes not affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @kalisp