Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Fix python 2 compatibility of ffmpeg and oiio tools discovery #4011

Merged
merged 1 commit into from Oct 20, 2022
Merged

General: Fix python 2 compatibility of ffmpeg and oiio tools discovery #4011

merged 1 commit into from Oct 20, 2022

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 20, 2022 •
edited

Brief description

This PR broke python 2 compatibility of ffmpeg and oiio tool discovery.

Description

Fixed missing DEVNULL constant in subprocess module for python 2. It is replaced with fake devnull file handler.

Testing notes:

  1. Try to get ffmpeg or oiio tools in Python 2 DCC

@iLLiCiTiT iLLiCiTiT self-assigned this Oct 20, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Oct 20, 2022
@iLLiCiTiT iLLiCiTiT requested a review from 64qam October 20, 2022 10:51
@iLLiCiTiT iLLiCiTiT merged commit 38f2484 into develop Oct 20, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/tools_discovery_for_py2 branch October 20, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @64qam