-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alembic Loader as Arnold Standin #4047
Alembic Loader as Arnold Standin #4047
Conversation
Task linked: OP-4267 Alembic loader as Arnold Standin |
families = ["model", "pointcache"] | ||
representations = ["abc"] | ||
|
||
label = "Import Alembic as Standin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this label should at least mention Arnold.
def load(self, context, name, namespace, options): | ||
|
||
import maya.cmds as cmds | ||
import pymel.core as pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With issue #2353 open I'd recommend avoiding Pymel where possible and rewriting this using maya cmds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I also noticed another ArnoldStandin Loader would have an error message of Error: Problem with the API object returned by __apiobject__ method
when loading ass file under some circumstance(but the ass file is still successfully loaded). I guess it's related to the pymel command too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ve tested it maya2023
with arnold 5.1.3.3
Model imports as ASS file normally. Small note tho: use sequence is "ON" should be considered that model being static in general so should be "OFF" by nature
Speaking of Point cache at first everything seems fine and working however I ve got weird anim problems...double checked it and manually created ass.file from the same workfile and my version had no issues.
Seems like some ASS creation params being wrong set. Need revision and testing.
Same frame different animation:
One more thing to consider why not allow user to "Import Alembic as ASS file" even when speaking about Animation caches not just Pointcaches in general (pyblished animation alembics) could be pretty handy and also there shouldnt be any reason to not allow it too...
so user could import these families as ASS:
model
(already present)
pointcache
(already present)
animation
(not present now)
Cool, thx. Pls tell me when you made the last change (the one left for your morning time) so I will tested on this "final" version...not before. Cheers! |
Now it works normally, did tests in I think the problem with animation mismatch was caused by difference in framerates (25fps vs 29.97) even present in pyblished abc using OP tools. So it was not on your side! Question is if special care should be taken. I mean taking note of fps from origin of the abc file (source animation maya scene). As I understand you read this from database and set it according to it right? Also static models still have Thanks! |
Have made another testing and all the features are already working fine! There is one thing which prevents the approval... There is really minor issue that is Otherwise all works perfectly! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems working fine! Thx
Brief description
Adding Alembic Loader as Arnold Standin function as the Openpype Plugin
Description
The user can load the published workfileswith abc format as Arnold Standin if the pusblished workfiles belong to model and pointcache family.
Additional info
Doesn't have any for the current stage
Testing notes: