OP-2566: remove underscore from subset name

[moonyuet]

Brief description

remove unnecessary underscore from subset name when rendering without AOVs

Description

When publishing the render with the empty AOV name, it will create subset name with underscore at the end. (See the screenshot below)

This PR will fix the issue of adding extra underscore at the end when publishing the render.

Additional info

This is only tested in maya Host.

Testing notes:

1. Launch Maya in Openpype
2. Create Render Main
3. In Render Setting, add an AOV and empties the AOV name
4. Save and Publish the scene.

[LiborBatek]

I have made a test with Specular AOV added besides the default beauty (with removed AOV name for that Specular AOV) with this outcome...

However I need you be more specific what conditions needed....should I just remove the name as I did for AOV? (its not very clear from your testing notes). See my picture. Also dont know if merge AOVs should be on or off. I have used defaults which is mergeAOVs to single exr file.

When I have these informations I will redo it again if need be. No it looks fine without any additional underscore in the name but not 100% sure if its okey right now.

Thx.

[moonyuet]

I have made a test with Specular AOV added besides the default beauty (with removed AOV name for that Specular AOV) with this outcome...

However I need you be more specific what conditions needed....should I just remove the name as I did for AOV? (its not very clear from your testing notes). See my picture. Also dont know if merge AOVs should be on or off. I have used defaults which is mergeAOVs to single exr file.

When I have these informations I will redo it again if need be. No it looks fine without any additional underscore in the name but not 100% sure if its okey right now.

Thx.

Hi Libor! I tested the code without turning on MergeAOVs, so that I can check to see if there's any extra underscore created after the AOV with the empty name. It's a weird ticket, you can check more information in ClickUp: https://app.clickup.com/t/6658547/OP-2566
https://app.clickup.com/t/6658547/OP-2622

[LiborBatek]

tested in maya2022 and maya2023
Ok, so I have made another go of test with "mergeAOVs" turned off and it works ok...

I have Main layer (beauty) + N pass (without deleting AOV name) + Specular AOV (with deleted name)...
creates

renderLightingMain_beauty
renderLightingMain (the spec AOV with deleted name) doesnt add any underscore into the name so OK!
renderLightingMain_N

[LiborBatek]

Seems working in both maya2022 and maya2023

[BigRoy]

Wouldn't this have been more succinct with something like this?

    subset_name = group_name
    if cam:
        subset_name += "_{}".format(cam)
    if aov:
        subset_name += "_{}".format(aov)

Or even:

    subset_name = group_name
    for suffix_element in [cam, aov]:
        if suffix_element:
            subset_name += "_{}".format(suffix_element)

Or even:

    parts = [part for part in [group_name, cam, aov] if part]
    subset_name = "_".join(parts)

Ok, that last one might be a bit too far for readability 😆

[BigRoy]

Just be sure - this is a backwards incompatible change in that existing renders would now generate a new subset without the underscore, correct?

[ynbot]

Task linked: OP-2566 remove underscore from subset name

[BigRoy]

Just be sure - this is a backwards incompatible change in that existing renders would now generate a new subset without the underscore, correct?

Just updated some things on our end and it seems this is definitely backwards incompatible.

Is there any way for legacy renders/scenes to still include the trailing _ to remain backwards compatible? Was there a setting for a project for that?

We're now getting publishes with a new name:

[BigRoy]

For now I added legacy support for a project on our end: BigRoy@92d12f2