General: Extract review single frame output #4064
Merged
+123
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Task linked: OP-4353 extract review single frame output |
64qam
approved these changes
Nov 7, 2022
iLLiCiTiT
deleted the
feature/OP-4353_extract-review-single-frame-output
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Extract review have different outputs when input is single frame.
Description
The goal is to avoid creating of single frame movie files but also give ability to create different review output and define it's resolution and tags. We've added one more additional filtering to output defintinions. It is possible to tell that the output will be created always (no matter how many frames input has), when input has 1 frame image or when input has 2+ images (or is movie).
Added default output definition to create HD png output if input is single frame and h264 is created only if input is video or has multiple frames.
Testing notes:
Your current settings should work as they did before (nothing should break with older settings).
To test the feature: Change your settings to create an output definition on single frame, another output definition on multi frame and another output definition which is created always. You can add letterboxes with different colors to know which is which.
Run publishing in all of those cases e.g. by using tray publisher where can be passed reviewable.