Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publisher: Fix cache of asset docs #4070

Merged
merged 1 commit into from Nov 4, 2022
Merged

Publisher: Fix cache of asset docs #4070

merged 1 commit into from Nov 4, 2022
+2 −2

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Asset docs cache may store generator instead of list of asset documents.

Description

This is future proof change that makes sure the output of get_assets is converted to list if is generator.

Testing notes:

  1. Nothing should change visually
  2. Assets should be loaded in publisher UI

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 4, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 4, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Nov 4, 2022
@iLLiCiTiT iLLiCiTiT merged commit 5472201 into develop Nov 4, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/publisher_asset_cache branch November 4, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@kalisp kalisp Awaiting requested review from kalisp

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.14.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @64qam