Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hiero: creator from settings with set maximum #4077

Merged
merged 1 commit into from
Nov 8, 2022
Merged

hiero: creator from settings with set maximum #4077

merged 1 commit into from
Nov 8, 2022
+6 −3

Conversation

jakubjezek001
Copy link
Member

Brief description

Fixing wrong value in ui set from settings

Description

Settings value was not correctly transferred onto creator ui.

Testing notes:

  1. Open Hiero workfile
  2. select a clip and hit OP Creator
  3. Look to down to workfile start frame and it should be 1001

@jakubjezek001 jakubjezek001 self-assigned this Nov 7, 2022
@ynbot
Copy link
Contributor

ynbot commented Nov 7, 2022

Task linked: OP-4377 Hiero - creator settings frame start 99

@jakubjezek001 jakubjezek001 added host: Hiero type: bug Something isn't working labels Nov 7, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 7, 2022
jrsndl
jrsndl approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@jrsndl jrsndl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. The project_settings/hiero/create/CreateShotClip/workfileFrameStart now doesn't max to 99.
BTW this is only problem for Hiero/NS 13+, settings works withouth issue in Hiero 12.2.

@jakubjezek001 jakubjezek001 merged commit 1ee5ff6 into develop Nov 8, 2022
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-4377_Hiero-creator-settings-frame-start-99 branch November 8, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrsndl jrsndl jrsndl approved these changes

@64qam 64qam Awaiting requested review from 64qam

Assignees

@jakubjezek001 jakubjezek001

Labels
host: Hiero type: bug Something isn't working
Projects
None yet
Milestone
3.14.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubjezek001 @ynbot @jrsndl