Maya: aov filtering

[moonyuet]

Brief description

fixing the bug for the regex filter not excluding the aov in RedShift
See(#4057)

Description

Multipart boolean option of the renderers (RedShift and Arnold) is broken in lib_renderproduct.py, which submits a wrong information to collect_render.py(i.e. multipart is always True even when it is being turned off..), This cause the review option not working with regex filters, which depends on whether multipart is on /off.

For this fix,
if “force combine beauty and AOVs into single file” or “multipart EXR” in Redshift Render Setting is off, it will filter out the renderpass according to the regex filter set in the Openpype Setting. (I set .([Bb]eauty). as filter)

If either one is on, it will show both beauty and Cryptomatte pass.

If mergeAOVs or multipart in Arnold Render Setting is off, it will filter out the renderpass in regards to the regex filter set in the Openpype setting. .

If multipart is on, it will render all the passes for the multipart option (I am not sure if it’s a good idea. so let me know if you also want the filter option included here.)

while it will just only render beauty pass for mergeAOVs

Additional info

No Additional Info

Testing Notes

1. check if you have disable the "multipart" or "force combine beauty and AOVs" in Redshift Render Setting OR
   check if you have disable the "mutlipart" or "Merge AOVs" in Arnold Render Setting.
   
   

2. set your regex filter in deadline setting
   

3. add the AOV maps
   

4. Create the render instance and run the publisher

[m-u-r-p-h-y]

the render settings under project_settings/maya/RenderSettings should only be used as render presets, not for evaluation during rendering. We should always take the settings from the render scene itself.

[moonyuet]

the render settings under project_settings/maya/RenderSettings should only be used as render presets, not for evaluation during rendering. We should always take the settings from the render scene itself.

I find out that the boolean of multipart in collect_render.py doesn't align with that of multipart in lib_renderproduct.py, I have edited the lib_renderproduct.py so that the multipart works properly in Redshift. For Arnold, I still want to see if you guys want to have the filtering even if the multipart is on as it seems that it still renders all passes when the multipart is on.

[ynbot]

Task linked: OP-4341 aov filtering

[LiborBatek]

I have tested it for maya2022 with Arnold and everything works correctly. All render layers published ok and only Beauty has review movie file and the rest of the AOVs are without review movie.

However I have encountered problems when testing with Redshift I cant publish render because of file name prefix issue.
See pic

Also the repair action do not fix it (seems like the logic is wrong for redshift).

Repair action sets prefixes like this: <Scene>/<RenderLayer>/<RenderLayer> however when Multipart EXR and or Force Combine Beauty and AOVs into single file are off there should be set file name prefix like
<Scene>/<RenderLayer>/<RenderLayer>_<RenderPass>

I guess this should been already addressed in this PR #3880

[m-u-r-p-h-y]

tested the redshift and there is a problem with the code which was taking care of Redshift change of Beauty name to BeautyAux

you can see actually rendered files and the content of the JSON file with the wrong expected files

[LiborBatek]

So now it works also in Redshift. Seems ok to me. Not spotted any problems.

[antirotor]

Just some minor cosmetic changes

[antirotor]

I would just remove this

[antirotor]

Suggested change

	self.log.info("preview:{}".format(preview))
	self.log.debug("preview:{}".format(preview))

[antirotor]

Suggested change

	self.log.info("instances:{}".format(instances))
	self.log.debug("instances:{}".format(instances))

tested and reviewed by others