Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Igniter: fix regex to match semver better #4085

Merged
merged 1 commit into from Nov 11, 2022

Conversation

antirotor
Copy link
Member

Fix

This should fix the case where multiple hyphens were used in staging version pre-release part.

foo-v3.14.6-nightly.2-x-y-x+staging were not matched properly and so the staging status of the version couldn't be determined.

This happened with --list-versions --use-staging and when staging version was not set in the Settings (so the latest compatible with the build should be used)

How to test

Create multiple versions in update repository like

foo-3.14.6+staging
goo-3.14.6-something.1+staging
hoo-3.14.6-something-else.1+staging.boo

then

openpype-console --list-versions --use-staging

should list them all

Note
This will be probably obsolete in 3.15 where staging logic will be dropped. See #3979

this fixes issues determining staging version from file name where multiple hyphens are used in pre-releas/buildmetadata part of the version string
@antirotor antirotor added the type: bug Something isn't working label Nov 10, 2022
@antirotor antirotor self-assigned this Nov 10, 2022
@github-actions github-actions bot added this to the next-patch milestone Nov 10, 2022
@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@antirotor antirotor merged commit d1ba290 into develop Nov 11, 2022
@antirotor antirotor deleted the bugfix/regex-to-determine-staging branch November 11, 2022 17:26
@github-actions github-actions bot added this to the next-patch milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants