Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Report Viewer: Fix small bugs #4086

Merged
merged 2 commits into from Nov 11, 2022
Merged

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Small fixes in publish report viewer.

Description

Fix delete button position on row insert. The button was offset on first item insert because of outdate viewport size. Fix issue when all report items are removed. In that case it set report as None which was not checked.

Testing notes:

  • adding first report item should not offset remove button
  • removing last remaining item from report tool should not cause crash

@github-actions github-actions bot added this to the next-patch milestone Nov 10, 2022
@iLLiCiTiT iLLiCiTiT self-assigned this Nov 10, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Nov 10, 2022
@jakubjezek001 jakubjezek001 removed this from the next-patch milestone Nov 10, 2022
@iLLiCiTiT iLLiCiTiT merged commit c6e8bc4 into develop Nov 11, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/publish_report_viewer branch November 11, 2022 09:59
@github-actions github-actions bot added this to the next-patch milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants