Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files Widget: Ignore case sensitivity of extensions #4096

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Files Widget: Ignore case sensitivity of extensions #4096

merged 1 commit into from
Nov 15, 2022

Conversation

iLLiCiTiT
Copy link
Member

Brief description

Files widget is not case sensitive about dropped files.

Description

Files widget validation of dropped files use extension as one of filters, but extensions dropped files were not lowered so the validation didn't allow to enter e.g. .PNG files.

Testing notes:

  1. Prepare e.g. png file with upper case extensions
  2. Open TrayPublisher
  3. Select Image family and tray drop the file to file input
  4. It should allow you to drop it and publishing should finish successfully

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 14, 2022
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Nov 14, 2022
@iLLiCiTiT iLLiCiTiT requested a review from 64qam November 14, 2022 17:32
@iLLiCiTiT iLLiCiTiT merged commit ffac58e into develop Nov 15, 2022
@iLLiCiTiT iLLiCiTiT deleted the bugfix/extension_case_insensitive branch November 15, 2022 12:15
@github-actions github-actions bot added this to the next-patch milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
3.14.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iLLiCiTiT @64qam