Slack: notification fail in new tray publisher #4118
Merged
+29
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
published_path might be missing in case of thumbnail not getting published. This implementation takes from staging if published_path not present
In legacy cases task might be only string with its name, not structure with additional metadata (type etc.). This implementation handles that.
It should take task from instance anatomyData, then from context and handle non dict items.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -112,7 +112,13 @@ def _get_filled_message(self, message_templ, instance, review_path=None): | |||
| if review_path: | |||
| fill_pairs.append(("review_filepath", review_path)) | |||
|
|
|||
| task_data = fill_data.get("task") | |||
| task_data = ( | |||
| copy.deepcopy(instance.data.get("anatomyData", {})).get("task") | |||
There was a problem hiding this comment.
continuation line over-indented for hanging indent
Task types didn't work.
64qam
approved these changes
Nov 23, 2022
kalisp
deleted the
bugfix/OP-4196_Slack-notification-fail-in-New-Tray-Publisher
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
This handles issue with missing 'published_path' key caused by not publishing thumbnail.
Additional info
It also handles task better, it takes task info from instance first, handles legacy case when task data is only string and not dict as expected.
Testing notes:
project_settings/slack/publish/CollectSlackFamilies/profiles/0/channel_messages/0/channels/0project_settings/global/publish/PreIntegrateThumbnails