Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: Find executable enhancement #4137

Merged
merged 3 commits into from Nov 24, 2022
Merged

General: Find executable enhancement #4137

merged 3 commits into from Nov 24, 2022
+53 −26

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Nov 24, 2022 •
edited

Brief description

Enhance how executables are found when find_executable is called which cause that oiiotools return full path to executable.

Description

Modified function find_executable which can now also fill extension to path to executable if is missing. With this change oiiotools return full path to executable with extension.

Additional information

Proper fix of previous issue from PR #4136 .

Testing notes:

Open Tray > Admin > Console and run this script:

from openpype.lib import get_oiio_tools_path

print(get_oiio_tools_path("oiiotool"))
print(get_oiio_tools_path("maketx"))

Output on windows should return full path to executabls with extensions. It should also still work on linux and mac (if the executables are available there).

@iLLiCiTiT iLLiCiTiT self-assigned this Nov 24, 2022
@iLLiCiTiT iLLiCiTiT added the type: enhancement Enhancements to existing functionality label Nov 24, 2022
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

image

@iLLiCiTiT iLLiCiTiT merged commit 6ccd3ee into develop Nov 24, 2022
@iLLiCiTiT iLLiCiTiT deleted the feature/find_executable_enhancement branch November 24, 2022 16:43
@github-actions github-actions bot added this to the next-patch milestone Nov 24, 2022
@jakubjezek001 jakubjezek001 modified the milestones: 3.14.7, next-patch Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam Awaiting requested review from 64qam

@antirotor antirotor Awaiting requested review from antirotor

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: enhancement Enhancements to existing functionality
Projects
None yet
Milestone
3.14.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iLLiCiTiT @m-u-r-p-h-y @jakubjezek001